update code size in UpdateAccount + remove update from UpdateAccountCode #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Jul 12, 2024
trie/verkle.go
Outdated
Comment on lines
466
to
472
| // Reuse the calculated key to also update the code size. | ||
| if i == 0 { | ||
| cs := make([]byte, 32) | ||
| binary.LittleEndian.PutUint64(cs, uint64(len(code))) | ||
| values[utils.CodeSizeLeafKey] = cs | ||
| } | ||
|
|
There was a problem hiding this comment.
not sure why yet, but this is what kills the shadowfork + verkle-at-genesis testnets. TBC
gballet
force-pushed
the
nyota-costs-redo
branch
from
360a860
to
4133497
Compare
gballet
force-pushed
the
nyota-costs-redo
branch
2 times, most recently
from
a0dad15
to
eae2aaa
Compare
gballet
force-pushed
the
nyota-costs-redo
branch
from
eae2aaa
to
4133497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.